Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Credentials #835

Closed
1 of 4 tasks
sammachin opened this issue Aug 1, 2022 · 4 comments · Fixed by #1056
Closed
1 of 4 tasks

Import Credentials #835

sammachin opened this issue Aug 1, 2022 · 4 comments · Fixed by #1056
Assignees
Labels
scope:node-red Features for FlowFuse to boost the vanilla Node-RED experience size:S - 2 Sizing estimation point story A user-oriented description of a feature
Milestone

Comments

@sammachin
Copy link
Contributor

Epic

No response

Description

As a: user

I want to: import a credentials file from another Node-RED into my project

So that: I can migrate my projects to FlowForge more easily.

Need to decide what to do with existing credentials in the project, ideally they would be merged, although for MVP it would be viable to make this only available if a project does not already have any credentials.
Ideally this would be available from the project settings page at any time after a project has been created, but it could also be part of project creation.
The user should have a dialog to upload or paste a credentials file and then enter the credentials secret.
There should be validation of the secret as part of the import.

Which customers would this be availble to

  • All Users, (CE)
  • Specific Project Types (EE)
  • Specific Team Tiers (EE)
  • Other (See comments)

Acceptance Criteria

No response

@sammachin sammachin added story A user-oriented description of a feature scope:node-red Features for FlowFuse to boost the vanilla Node-RED experience labels Aug 1, 2022
@sammachin sammachin added this to the 1.1 milestone Sep 12, 2022
@knolleary
Copy link
Member

There is a choice as to whether this is done in Node-RED or FlowForge.

Within Node-RED it would sit as part of the existing Import dialog.

If we do it at the FlowForge level, then I see it more a case of being able to import a Flow+Credential pair of files and have that replace the entire existing configuration rather than try to merge anything. I don't see the scenario where you already have the flows in Node-RED but want to just upload a different credentials file. This could be an implicit 'Import existing project' workflow - where that project is a flow/credential pair of files and a credSecret if needed.

@knolleary
Copy link
Member

  • Add to the 'Danger' settings page an option to 'import flows'.
  • Triggers dialog:

Image

  • Credentials file is optional
  • If credentials file provided and contents are determined to be encrypted, then show prompt for credential secret.

@hardillb hardillb self-assigned this Oct 10, 2022
@hardillb
Copy link
Contributor

Getting close

Image

Just need to work out how to get hold of the actual File Input object to pass to the FileReader

@hardillb
Copy link
Contributor

Verified on Staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:node-red Features for FlowFuse to boost the vanilla Node-RED experience size:S - 2 Sizing estimation point story A user-oriented description of a feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants