Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When device is re-assigned to a new project old project & snapshot still run #888

Closed
sammachin opened this issue Aug 12, 2022 · 3 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@sammachin
Copy link
Contributor

Current Behavior

If I have a device and assign it to a Project, then set a target a snapshot of that project it runs fine.

However if I then assign the device to a different project, but don't set a target snapshot for that new project the device continues to pickup and run the original snapshot

Expected Behavior

Device should stop running the snapshot of the original project and sit waiting for a new one.

Steps To Reproduce

Create project A & device, assign device to project.
Create snapshot and set as target, ensure it is running on the device.

Stop device agent,

Create a 2nd project B, and assign the device to that new project, (observe that the device has been removed from project A)

Start device agent,

Observe that device is running Project A still

Environment

  • FlowForge version: 0.8.0 (staging)
  • Agent 0.2.0
  • Node.js version: 16.16
@sammachin sammachin added needs-triage Needs looking at to decide what to do bug Something isn't working labels Aug 12, 2022
@sammachin sammachin modified the milestones: 1.0, 0.9 Aug 22, 2022
@knolleary
Copy link
Member

My first attempts to recreate this have not been successful.

Following the steps to reproduce, using the latest code across the board, I see the new project running on the device after it is restarted. I cannot find any path that results in the old project to be restarted.

@sammachin
Copy link
Contributor Author

@knolleary do you have a target snapshot on project B? I'm pretty sure I didn't set one

@sammachin
Copy link
Contributor Author

I found the path that I used, its not in the latest release but is still there on prod
The devices screen in the project (not team) had the kebab menu which let you assign a device to another project from it,
image

Thats now gone and you can only manage the device (unassign, regen creds etc) from the team devices page. Which I think is correct. I'm not sure where that change was made though, #908 touched the table but I can't see the menu being removed

@sammachin sammachin closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants