Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing a theme color changes all the themes color #966

Open
mereshow opened this issue Jun 13, 2024 · 3 comments
Open

Changing a theme color changes all the themes color #966

mereshow opened this issue Jun 13, 2024 · 3 comments
Labels
bug Something isn't working size:XS - 1 Sizing estimation point

Comments

@mereshow
Copy link

Current Behavior

If you create a new theme, with a new name, and change a color of one of the themes, it changes the corresponding color on all the themes.

Expected Behavior

Each theme should be independent and changing a theme color should only be applied to that theme.

Steps To Reproduce

Go to: Dashboard 2.0 > Theming, clic on "+ Theme". Change a color on one of the themes and save it.

Environment

  • Dashboard version: 1.11.1
  • Node-RED version: 3.1.10
  • Node.js version: v16.20.2
  • npm version: 8.19.4
  • Platform/OS: NodeRed on Docker (Linux 5.15.0-112-generic x64 LE)
  • Browser: Chrome

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@mereshow mereshow added bug Something isn't working needs-triage Needs looking at to decide what to do labels Jun 13, 2024
@joepavitt
Copy link
Collaborator

joepavitt commented Jun 13, 2024

Can you grab a screen recording of this please, I'm not able to reproduce locally, it works okay for me, note that none of the other themes are modified:

Screen.Recording.2024-06-13.at.18.04.14.mov

@mereshow
Copy link
Author

In my case it happens only if the themes are not associated to any page (and it only affects those themes).

Screencast.from.13-06-24.20.31.03.webm

@joepavitt
Copy link
Collaborator

Ooh funky - good find. Thanks, will make sure that's addressed.

@joepavitt joepavitt added size:XS - 1 Sizing estimation point and removed needs-triage Needs looking at to decide what to do labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS - 1 Sizing estimation point
Projects
Status: Backlog
Development

No branches or pull requests

2 participants