Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-dropdown doesnt pass correct value for multiple select options - and when msg pass through is enabled. #993

Open
SandeepAgarwal13 opened this issue Jun 19, 2024 · 2 comments
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do size:S - 2 Sizing estimation point

Comments

@SandeepAgarwal13
Copy link

Current Behavior

For other dashboard nodes - when the nodes are marked allow msg to pass through they retain the msg.payload values
For ui-drop dashboard node - when msg.payload is a string - the node retains the msg.paylod value (the nodes are marked allow msg to pass through )

For ui-drop dashboard node - when msg.payload is a an array and multiple selection is set to true- the node doesnt retains the msg.paylod value

Expected Behavior

For ui-drop dashboard node - when msg.payload is a an array and multiple selection is set to true- the node should retains the msg.paylod value - similar to other nodes which retain msg.payload when "allow msg to act as pass through is selected"

Steps To Reproduce

Create a ui dropdown node with multiple select on and allow msg to pass through.
Pass a message with msg.paylod as array (multiple selection).
Check the result.

Environment

  • Dashboard version:1.11
  • Node-RED version:3.1.9
  • Node.js version:20.10.0
  • npm version:10.2.3
  • Platform/OS:Windows
  • Browser:Chrome

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@SandeepAgarwal13 SandeepAgarwal13 added bug Something isn't working needs-triage Needs looking at to decide what to do labels Jun 19, 2024
@joepavitt joepavitt added the size:S - 2 Sizing estimation point label Jun 20, 2024
@bartbutenaers
Copy link
Contributor

Hi @SandeepAgarwal13,

I have tried to reproduce it, but for me both the string and array payload are being passed through:

image

Can you share a simple flow that allows me to reproduce it?

BTW I executed my test on version v1.12.0 which was released today. I have not tried an older version.

@SandeepAgarwal13
Copy link
Author

I rechecked this. This seems to be working. Let me spend more time and come back if i made a mistake :-(.
Regret to have wasted your time.
Let me monitor for few days - else will cancel it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do size:S - 2 Sizing estimation point
Projects
Status: Under Review
Development

No branches or pull requests

3 participants