Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port order match order specified in component #19

Closed
forresto opened this issue Oct 18, 2013 · 5 comments
Closed

port order match order specified in component #19

forresto opened this issue Oct 18, 2013 · 5 comments
Labels

Comments

@forresto
Copy link
Collaborator

I think this is important for muscle memory. After the initial ports are loaded based on the connections present in the graph, we will need to correct the order once the info is loaded from the library.

Otherwise...
screen shot 2013-10-18 at 2 56 56 pm

@bergie
Copy link
Member

bergie commented Oct 18, 2013

This is doubly important in the new editor as we don't show the port labels before you zoom

https://developer.mozilla.org/en-US/docs/Web/API/Node.insertBefore

@forresto
Copy link
Collaborator Author

    this.libraryComponent.inports.forEach(function (port) {
      this.inports.unshift(port);
    }.bind(this));
    this.libraryComponent.outports.forEach(function (port) {
      this.outports.unshift(port);
    }.bind(this));

at https://github.com/the-grid/the-graph/blob/master/the-graph-process/the-graph-process.html#L70 fixes it. So where are they getting reversed?

@forresto
Copy link
Collaborator Author

Aha. They are correct in the array (and dom), but the positioning in the-graph-port is reversed.

@bergie
Copy link
Member

bergie commented Oct 25, 2013

@forresto you may want to look also at #33 while fixing this.

@forresto
Copy link
Collaborator Author

e72e9f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants