Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix flowise-* dependencies version in package.json #1695

Open
tirongi opened this issue Feb 7, 2024 · 2 comments
Open

[BUG] Fix flowise-* dependencies version in package.json #1695

tirongi opened this issue Feb 7, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@tirongi
Copy link
Contributor

tirongi commented Feb 7, 2024

Describe the bug
When you install an older version of flowise, this will install the latest flowise-ui and flowise-components bringing to a different environment than the original 1.4.10 version.

To Reproduce
As instance try to install flowise@1.4.10 with: npm i -g flowise@1.4.10

Expected behavior
I expect that this version would download as dependencies respectively flowise-ui@1.4.7 and flowise-components@1.5.1 (the latest working versions of the two deps at the time of version freezing), instead in the package.json is specified to download the latest version.

In order to have a pure flowise@1.4.10 I have to force the installation of the two dependencies after the main install by going into the flowise install folder and send an "npm i flowise-ui@1.4.7" and "npm i flowise-components@1.5.1".

@HenryHengZJ
Copy link
Contributor

hmm do you have any suggestion on how to achieve that?

@HenryHengZJ HenryHengZJ added enhancement New feature or request bug Something isn't working labels Feb 10, 2024
@tirongi
Copy link
Contributor Author

tirongi commented Feb 12, 2024

IMHO, the best solution would be to use a version numbering that was coherent with the "compatibility family" among the flowise* components ensuring to follow the <major>.<minor>.<patch> pattern.
Then, assuming that versioning follow this criteria, you can set in the package.json a line like "flowise-components":"~1.4.0" in order to tell it to install latest 1.4.x available (instead of "*", actually used, that will point to the latest also when you install an older version of the software).

Starting from the next release of Flowise I would suggest to use as such of numbering and setup in the package.json to set and preserve the required version of each flowise-*.
In order to fix older versions, maybe occur to modify each package.json with the latest working release and set the release label in git to these fixed versions.

As always, thanks a lot for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants