New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to use ES6: rollup+babel transpilation #309
Conversation
- babel: use bable-env + browserlist to transpile for a wider range of browsers. - For that purpose, switch to `rollup` with way handier and more modern than browserify. - In order to keep the toolchain backward-compatible (and reduce the MR surface), use `grunt:exec` to wrap `rollup` execution.
You are doing a huge upgrade and that's great. Would you like to be added as a maintainer of this project? |
As long as someone keeps reviewing PR, I've no problem with this but I can't guarantee long-term involvement. Still, about that specific PR, I don't understand why the CI fails, is this something you could fix to get this green? |
It looks like it can't generate karma coverage report because coverage plugin is missing. Though all the tests pass. |
I guess the plugin is not loaded (anymore) because node can't parse |
https://travis-ci.org/github/flowjs/flow.js/jobs/724987732
It looks like coverage was created, but with different format or empty file. |
can you test if |
Could you set your CC_TEST_REPORTER_ID if different from It's not doing coverage reporting (0-size file). But I don't understand which tool is actually in charge of code instrumentation? |
Great job, it works! I have added you to the maintainers of this project. Once finished, your branch will be released as v3.0.0 flowjs since it supports promises. Please don't forget documentation too 🥇 |
Does not work. |
code-coverage fixed. |
Yes please, squash it and push it to v3 branch. Feel free to do it yourself, you have all the permissions you need. We need some time to release it to master once it's tested. |
Note: The update to |
…h happen to have a bug when `--single-run=false` is used. This commit: - move more of the static Karma configuration from Gruntfile back into karma.conf - add two SauceLabs browsers flavors - add a guard when karma:saucelabs is used without defined SauceLabs credentials
In flowjs#314 (a0eafbc) we updated karma-sauce-launcher from v0 to v4 but v2 introduced a bug keeping `--single-run=false` from working. This commit: - moves more of the static Karma configuration from Gruntfile back into karma.conf - adds two SauceLabs browsers flavors - adds a guard when karma:saucelabs is used without defined SauceLabs credentials - disables the saucelabs in the default karma config to restore `--single-run=false` until karma-runner/karma-sauce-launcher#217 is fixed.
This change gives the opportunity to use ES6 for
src/flow.js
rollup
with way handier and more modern than browserify.grunt:exec
to wraprollup
execution.Also update to
karma-coverage
v2 needed forasync
support as discussed and anticipated in #304.