fix(remote): fix plugin not working with remote extension pack on win…

…dows

closes #336

flow-libs/vscode.js.flow

@@ -4041,6 +4041,9 @@ declare module 'vscode' {
      * Extensions must create this directory before writing to it. The parent directory will always exist.
      */
     +logDirectory: string;
+
+    // NOTE: only present in vscode >= 1.35
+    +executionContext?: 1 | 2;
     /* END PROPOSED *********************************************************************************/
   }
 

lib/flowLSP/FlowLanguageClient/FlowLanguageClient.js

@@ -33,6 +33,7 @@ type Options = {|
   flowconfigPath: string,
   workspaceRoot: string,
   outputChannel: vscode.OutputChannel,
+  canUseRelativePattern: boolean,
   getConfig: () => Config,
 |};
 
@@ -167,11 +168,11 @@ export default class FlowLanguageClient {
       // options: { cwd: flowconfigDir },
     };
 
-    // all files inside flowconfigDir
-    const pattern: vscode.RelativePattern = new vscode.RelativePattern(
-      flowconfigDir,
-      '**/*',
-    );
+    const patternGlob = '**/*';
+    const pattern: vscode.GlobPattern = this._options.canUseRelativePattern
+      ? // all files inside flowconfigDir
+        new vscode.RelativePattern(flowconfigDir, patternGlob)
+      : patternGlob;
 
     const clientOptions: lsp.LanguageClientOptions = {
       // NOTE: nested .flowconfig filtering not possible using only documentSelector

lib/flowLSP/handlers.js

@@ -51,6 +51,7 @@ export function onDidOpenTextDocument(
   clients: FlowClients,
   document: vscode.TextDocument,
   outputChannel: vscode.OutputChannel,
+  canUseRelativePattern: boolean,
   logger: Logger,
 ) {
   if (!vscode.languages.match(activationDocumentSelector, document)) {
@@ -98,6 +99,7 @@ export function onDidOpenTextDocument(
       flowconfigPath,
       workspaceRoot: workspaceFolder.uri.fsPath,
       outputChannel,
+      canUseRelativePattern,
       // NOTE: passing config as getFunction instead of plain object
       // to add support of handling config change without the requirement of vscode restart
       getConfig: () => {

lib/flowLSP/index.js

@@ -6,21 +6,29 @@ import FlowClients from './FlowClients';
 import PluginCommands from './PluginCommands';
 import * as handlers from './handlers';
 
+import checkRelativePatternSupported from './utils/checkRelativePatternSupported';
 import Logger from './utils/Logger';
 
 export function activate(context: vscode.ExtensionContext) {
   const outputChannel = vscode.window.createOutputChannel('Flow');
   const logger = new Logger('', outputChannel, 'error');
   const clients = new FlowClients(logger);
   const commands = new PluginCommands(clients, outputChannel);
+  const canUseRelativePattern = checkRelativePatternSupported(context);
 
   logger.info('Open javascript or flowconfig to start flow.');
 
   context.subscriptions.push(
     clients,
     // handlers
     vscode.workspace.onDidOpenTextDocument((document) => {
-      handlers.onDidOpenTextDocument(clients, document, outputChannel, logger);
+      handlers.onDidOpenTextDocument(
+        clients,
+        document,
+        outputChannel,
+        canUseRelativePattern,
+        logger,
+      );
     }),
     vscode.window.onDidChangeActiveTextEditor((editor) => {
       handlers.onDidChangeActiveTextEditor(clients, editor);
@@ -43,6 +51,12 @@ export function activate(context: vscode.ExtensionContext) {
 
   // create flow clients for currently opened documents
   vscode.workspace.textDocuments.forEach((document) => {
-    handlers.onDidOpenTextDocument(clients, document, outputChannel, logger);
+    handlers.onDidOpenTextDocument(
+      clients,
+      document,
+      outputChannel,
+      canUseRelativePattern,
+      logger,
+    );
   });
 }

lib/flowLSP/utils/checkRelativePatternSupported.js

@@ -0,0 +1,14 @@
+/* @flow */
+import { ExtensionContext } from 'vscode';
+
+const EXECUTION_CONTEXT_REMOTE = 2;
+
+export default function checkRelativePatternSupported(
+  context: ExtensionContext,
+): boolean {
+  // NOTE: vscode.RelativePattern is not working when extension run using
+  // remote extension pack on windows (on linux it's working fine)
+  // it's not possible to detect local maching is linux or windows
+  // so disabling in all cases if extension is running remotely
+  return context.executionContext !== EXECUTION_CONTEXT_REMOTE;
+}