Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets the global git info before running specs in Travis #1064

Merged
merged 1 commit into from Jul 23, 2017
Merged

Sets the global git info before running specs in Travis #1064

merged 1 commit into from Jul 23, 2017

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Jul 23, 2017

Closes #1055

This addresses the first problem in the linked issue. Setting the global git info stops the (pointless and confusing) error message below from appearing:

console.error src/lib/git.js:126
  { stderr: '\n*** Please tell me who you are.\n\nRun\n\n  git config --global user.email "you@example.com"\n  git config --global user.name "Your Name"\n\nto set your account\'s default identity.\nOmit --global to set the identity only in this repository.\n\nfatal: empty ident name (for <travis@testing-docker-860d44b1-130f-449f-8d40-65c325a11273.(none)>) not allowed\n',
    stdout: '',
    exitCode: 128 }
console.error src/commands/install.js:463
  !! Failed to install underscore at /tmp/install-cmd-test-dir-839512/flowProj/flow-typed/npm/underscore_v1.x.x.js
console.error src/commands/install.js:464
  ERROR: Error finding latest commit hash for definitions/npm/underscore_v1.x.x/flow_v0.38.x-/underscore_v1.x.x.js: undefined

@gantoine gantoine closed this Jul 23, 2017
@gantoine gantoine reopened this Jul 23, 2017
@marudor marudor merged commit 882affc into flow-typed:master Jul 23, 2017
@gantoine gantoine deleted the set-git-info-before-travis-spec branch July 29, 2017 17:03
mwalkerwells pushed a commit to mwalkerwells/flow-typed that referenced this pull request Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants