Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definition for re-reselect #1951

Merged
merged 1 commit into from Mar 13, 2018
Merged

Add type definition for re-reselect #1951

merged 1 commit into from Mar 13, 2018

Conversation

rickharris
Copy link
Contributor

re-reselect is a simple wrapper on top of reselect that adds the ability to have multiple caches per-selector when you provide it a cache key. This definition is copied and pasted from the definition for reselect and modified to support the additional function required to generate a cache key.

I hope to have followed the contribution guidelines correctly, please let me know if I didn't understand something correctly. A couple of notes regarding the guidelines:

  1. There is an any value in here that is copied and pasted from reselect's definition. I wasn't quite confident enough to change it to something else.
  2. I'd like for this to support more versions, but flow 0.65 and below didn't much care for the parts I added. So, the range for this is defined as flow_v0.66.x-.

Thanks and please let me know if there's anything I can do to make this more mergeable!

@gantoine gantoine merged commit ca09058 into flow-typed:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants