Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-eslint): implement runner #101

Merged
merged 9 commits into from
Oct 12, 2023
Merged

Conversation

matejchalk
Copy link
Collaborator

Closes #27

Notes

  • implemented and tested runner logic
  • runs ESLint via Node API and converts results to audit outputs
  • change audit outputs in models to include slug, but not other metadata (already provided in initializer, so unnecessary burden on plugin author)
    • added logic to core which looks up metadata by audit slug to create reports
  • since ESLint results only include failed rules, all audits slugs have to be passed to runner so that it can report passed audits
    • might also be necessary for other "linter" plugins (Stylelint, TypeScript), in which case the core could provide a built-in solution for it 🤔
  • additional entry point added for executable bin.js file
    image

Next steps

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to get this merged!

@matejchalk matejchalk merged commit 11cb336 into main Oct 12, 2023
6 checks passed
@matejchalk matejchalk deleted the eslint-plugin-runner branch October 12, 2023 11:05
@BioPhoton BioPhoton mentioned this pull request Oct 29, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ESLint runner
2 participants