Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messaging when upgrade only changes catalog page #1570

Closed
mkenigs opened this issue Jun 11, 2024 · 2 comments
Closed

Improve messaging when upgrade only changes catalog page #1570

mkenigs opened this issue Jun 11, 2024 · 2 comments
Assignees
Labels
product Tickets relevant to the flox product team and/or functional requirements team-cli Tickets relevant to the flox CLI team

Comments

@mkenigs
Copy link
Contributor

mkenigs commented Jun 11, 2024

In some cases, a flox upgrade will preserve derivations of all packages, but the catalog page/revision of nixpkgs will change. This prints the message:

ℹ️  No packages need to be upgraded in environment 'name'.

but then the lockfile is modified, which could be confusing.

We could either:

  1. Not write the changes to the lockfile. That discards the information that there isn't an upgrade at some point in time, which isn't meaningless. I'm not sure if it's valuable.
  2. Print the message (needs rewording):
ℹ️  No packages need to be upgraded in environment 'main'. A record of checking for an 'upgrade' was written to the lockfile.
@mkenigs
Copy link
Contributor Author

mkenigs commented Jun 11, 2024

Deciding between 1. and 2. above is user-facing, ping @ghudgins @jennymahmoudi

@jennymahmoudi
Copy link
Contributor

I would choose #1.

It sounds like we don't tell the user that "the catalog page/revision of nixpkgs will change" at all and if so, I'd agree that probably is not something we need to be user-facing right now.

@ghudgins ghudgins added duplicate team-cli Tickets relevant to the flox CLI team product Tickets relevant to the flox product team and/or functional requirements and removed duplicate labels Jun 12, 2024
@dcarley dcarley self-assigned this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product Tickets relevant to the flox product team and/or functional requirements team-cli Tickets relevant to the flox CLI team
Projects
None yet
Development

No branches or pull requests

5 participants