Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't override exclude of aws-sdk #9

Closed
jagregory opened this issue Dec 13, 2020 · 2 comments
Closed

Can't override exclude of aws-sdk #9

jagregory opened this issue Dec 13, 2020 · 2 comments
Labels

Comments

@jagregory
Copy link

The list of excluded packages is a union of whatever the user supplies and ['aws-sdk'], which means you can't not exclude aws-sdk.

const exclude = union(props.exclude || [], ['aws-sdk']);

As Lambda doesn't bundle the latest version of the SDK this can be a problem if you depend on a newer SDK version. Ideally in this scenario I'd just bundle aws-sdk until the Lambda version is updated.

@floydspace
Copy link
Owner

@jagregory yes it does make sense as we discussed with @jogold in this thread
I Will make the fix
Thank you for your input

@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants