Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin breaks with serverless 2.36.0 #117

Closed
taschmidt opened this issue Apr 20, 2021 · 1 comment · Fixed by #118
Closed

Plugin breaks with serverless 2.36.0 #117

taschmidt opened this issue Apr 20, 2021 · 1 comment · Fixed by #118

Comments

@taschmidt
Copy link
Contributor

After upgrading serverless to the just-released version 2.36.0, started receiving the following error:

  TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
      at validateString (internal/validators.js:124:11)
      at Object.join (path.js:1039:7)
      at new EsbuildPlugin (<project dir>/node_modules/serverless-esbuild/dist/index.js:48:33)

The problem appears to be dependence on the serverless.config.servicePath prop here:

this.workDirPath = path.join(this.serverless.config.servicePath, WORK_FOLDER);

This appears to have been renamed in 2.36.0:
https://github.com/serverless/serverless/releases/tag/v2.36.0

@olup
Copy link
Contributor

olup commented Apr 20, 2021

Thx a lot for reporting !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants