Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package individually also packages sourcemaps of other functions #91

Closed
kennand opened this issue Mar 1, 2021 · 1 comment · Fixed by #92
Closed

Package individually also packages sourcemaps of other functions #91

kennand opened this issue Mar 1, 2021 · 1 comment · Fixed by #92
Assignees

Comments

@kennand
Copy link

kennand commented Mar 1, 2021

#87 - this PR fixed the individual function packaging, but I'm noticing sourcemaps are still generated for the other functions (not the js files, just the js.map extensions).

To repro just have:

esbuild:
sourcemap: true
package:
individually: true

ps. thanks @olup for fixing the individual packaging bug!

@olup
Copy link
Contributor

olup commented Mar 1, 2021

Indeed, bundling and source mapping is done once for the whole project, then files are distributed over individual artifact archives, and this is done by exclusion of files. So performance wise it's the same, however you are right we should blacklist non relevant source maps. I'll fix that today or tomorrow.

@olup olup self-assigned this Mar 1, 2021
@olup olup linked a pull request Mar 1, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants