Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): Enhance message of type error [LNG-313] #1033

Merged
merged 3 commits into from
Jan 9, 2024
Merged

feat(compiler): Enhance message of type error [LNG-313] #1033

merged 3 commits into from
Jan 9, 2024

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Jan 5, 2024 •
edited
Loading

Description

Provide more descriptive message for type checking on ability or struct creation.

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear Linear
Copy link

linear bot commented Jan 5, 2024

LNG-313 Enhance message of type error

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Jan 5, 2024
DieMyst
DieMyst reviewed Jan 9, 2024
View reviewed changes
semantics/src/main/scala/aqua/semantics/rules/types/TypesInterpreter.scala
else
s"Unexpected argument '$name', did you mean $similar?"

report.warning(arg.argName, message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there is warning instead of error?

@DieMyst DieMyst merged commit d5cd77b into main Jan 9, 2024
10 checks passed
@DieMyst DieMyst deleted the feat/enhance-error-message-LNG-313 branch January 9, 2024 12:15
@fluencebot fluencebot mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DieMyst DieMyst DieMyst approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@InversionSpaces @DieMyst