Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Add outside context to closures [LNG-317] #1038

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix(compiler): Add outside context to closures [LNG-317] #1038

merged 2 commits into from
Jan 11, 2024

Conversation

DieMyst
Copy link
Member

@DieMyst DieMyst commented Jan 11, 2024 •
edited
Loading

Description

Nested closures cannot find arrows on inline step

Proposed Changes

Add correct context to closures.

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear Linear
Copy link

linear bot commented Jan 11, 2024

LNG-317 Services in closures don't pass between contexts

@DieMyst DieMyst added the e2e Run e2e workflow label Jan 11, 2024
@DieMyst DieMyst marked this pull request as ready for review January 11, 2024 06:55
@DieMyst DieMyst merged commit 85f3ecd into main Jan 11, 2024
14 of 20 checks passed
@DieMyst DieMyst deleted the LNG-317_closures_context branch January 11, 2024 08:00
@fluencebot fluencebot mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alari alari alari approved these changes

@InversionSpaces InversionSpaces Awaiting requested review from InversionSpaces

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DieMyst @alari