Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): Make on propagate errors [fixes LNG-203] #788

Merged
merged 11 commits into from Jul 12, 2023
Merged

feat(compiler): Make on propagate errors [fixes LNG-203] #788

merged 11 commits into from Jul 12, 2023

Conversation

InversionSpaces
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Jul 7, 2023

LNG-203 Make `on` propagate error with correct topology

Now on ... via ...is wrapped with xor with call to errorHadlingSrv in its right branch

To propagate error from on body it is needed to insert return to previous topology and fail %last_error% in xor right branch

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Jul 10, 2023
@InversionSpaces InversionSpaces force-pushed the feat/on-propagate-error branch 4 times, most recently from 41fa2d4 to 305f1cb Compare July 11, 2023 14:32
@InversionSpaces InversionSpaces marked this pull request as ready for review July 11, 2023 14:59
@InversionSpaces InversionSpaces enabled auto-merge (squash) July 12, 2023 13:17
@InversionSpaces InversionSpaces merged commit b8b0faf into main Jul 12, 2023
10 checks passed
@InversionSpaces InversionSpaces deleted the feat/on-propagate-error branch July 12, 2023 13:18
This was referenced Jul 14, 2023
Closed
Merged
@fluencebot fluencebot mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DieMyst DieMyst DieMyst approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@InversionSpaces @DieMyst