Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Unknown service method call is ignored [LNG-273] #957

Merged
merged 8 commits into from Nov 1, 2023

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Oct 31, 2023

Description

Report compilation errors on call to not existing method of ability or service.

Implementation Details

Refactor CallArrowRaw generation, add error report.

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear
Copy link

linear bot commented Oct 31, 2023

LNG-273 Unknown service method call is ignored

service Console("run-console"):
  print(log: i32)

func test() -> i32:
  Console.log(42)
  <- 42

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Oct 31, 2023
@InversionSpaces InversionSpaces marked this pull request as ready for review November 1, 2023 11:36
@InversionSpaces InversionSpaces enabled auto-merge (squash) November 1, 2023 11:55
@InversionSpaces InversionSpaces merged commit 5a3c5e6 into main Nov 1, 2023
10 checks passed
@InversionSpaces InversionSpaces deleted the fix/unknown-service-method-LNG-273 branch November 1, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants