Add built-in service to sign data and verify signatures #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justprosh
reviewed
Dec 6, 2021
coder11
changed the title
Co-authored-by: Aleksey Proshutisnkiy <justprosh@users.noreply.github.com>
justprosh
approved these changes
Dec 6, 2021
folex
reviewed
Dec 7, 2021
folex
reviewed
Dec 7, 2021
folex
reviewed
Dec 7, 2021
justprosh
reviewed
Dec 7, 2021
folex
requested changes
Dec 9, 2021
|
fixes #108 |
|
related: fluencelabs/aqua-lib#18 |
justprosh
approved these changes
Dec 9, 2021
folex
changed the title
folex
approved these changes
Dec 9, 2021
folex
reviewed
Dec 9, 2021
src/internal/builtInServices.ts
Outdated
| const error = (error: string): CallServiceResult => { | ||
| return { | ||
| result: error, | ||
| retCode: ResultCodes.unknownError, |
There was a problem hiding this comment.
Why is it always ResultCodes.unknownError?
There was a problem hiding this comment.
Seems like error code = 1 works fine. Do you have any ideas how to improve it?
There was a problem hiding this comment.
I just don't understand the meaning yet. You throw e.g.,
error(`All arguments of 'concat' must be arrays: arguments ${str} are not`);and it's an unknown error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.