Wrap master node in docker container #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DieMyst
reviewed
Dec 4, 2018
DieMyst
reviewed
Dec 4, 2018
| @@ -26,7 +27,7 @@ import io.circe.parser.parse | |||
| * | |||
| * @param masterTendermintPath Tendermint's home directory | |||
| */ | |||
| case class KeysPath(masterTendermintPath: String) extends slogging.LazyLogging { | |||
| case class KeysPath(masterTendermintPath: String)(implicit ec: ContextShift[IO]) extends slogging.LazyLogging { | |||
There was a problem hiding this comment.
why the implicit is needed here?
DieMyst
approved these changes
Dec 4, 2018
alari
previously requested changes
Dec 4, 2018
| @@ -7,7 +7,8 @@ matrix: | |||
| services: | |||
| - docker | |||
| install: | |||
| - docker pull fluencelabs/solver:latest | |||
| - docker pull fluencelabs/solver:2018-dec-demo | |||
There was a problem hiding this comment.
There problem is that I can't really release new docker images before I merge this PR to master, and tests in the PR won't pass before I release new docker images.
So this is a workaround, I will create the next pull request after I release new docker images as 'latest', where I will change images to latest everywhere.
| @@ -26,7 +27,7 @@ import io.circe.parser.parse | |||
| * | |||
| * @param masterTendermintPath Tendermint's home directory | |||
| */ | |||
| case class KeysPath(masterTendermintPath: String) extends slogging.LazyLogging { | |||
| case class KeysPath(masterTendermintPath: String)(implicit ec: ContextShift[IO]) extends slogging.LazyLogging { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
docker.sockUsage
docker run -e "TENDERMINT_IP=host.docker.internal" -e "PORTS=20000:20002" -v /var/run/docker.sock:/var/run/docker.sock -it fluencelabs/masterhost.docker.internalshould be used formacOS, on linux you can just pass your IP