Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: propagate errors from linked modules #388

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

ValeryAntopol
Copy link
Collaborator

No description provided.

@ValeryAntopol ValeryAntopol marked this pull request as ready for review October 31, 2023 19:06
@ValeryAntopol ValeryAntopol changed the title feat!: add memory limiting, propagate errors from linked modules feat!: propagate errors from linked modules Nov 1, 2023
Copy link
Member

@mikevoronov mikevoronov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Cargo.toml Outdated Show resolved Hide resolved
@fluencebot fluencebot added the e2e Run e2e workflow label Nov 2, 2023
Copy link

github-actions bot commented Nov 3, 2023

Pull Request Test Coverage Report for Build 6744768300

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 49 (0.0%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.001%) to 0.417%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/module/exports.rs 0 1 0.0%
core/src/module/wit_function.rs 0 3 0.0%
crates/wasmtime-backend/src/function.rs 0 4 0.0%
core/src/host_imports/imports.rs 0 7 0.0%
crates/js-backend/src/function.rs 0 13 0.0%
core/src/module/marine_module.rs 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/host_imports/imports.rs 1 0.0%
crates/wasmtime-backend/src/lib.rs 4 0.0%
Totals Coverage Status
Change from base Build 6616846004: -0.001%
Covered Lines: 31
Relevant Lines: 7440

💛 - Coveralls

@ValeryAntopol ValeryAntopol merged commit a94494b into master Nov 3, 2023
19 of 20 checks passed
@ValeryAntopol ValeryAntopol deleted the feat/it-with-error-propagation branch November 3, 2023 14:43
@fluencebot fluencebot mentioned this pull request Nov 3, 2023
@coveralls
Copy link

coveralls commented Feb 7, 2024

Pull Request Test Coverage Report for Build 6744768300

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 49 (0.0%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.001%) to 0.417%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/module/exports.rs 0 1 0.0%
core/src/module/wit_function.rs 0 3 0.0%
crates/wasmtime-backend/src/function.rs 0 4 0.0%
core/src/host_imports/imports.rs 0 7 0.0%
crates/js-backend/src/function.rs 0 13 0.0%
core/src/module/marine_module.rs 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/host_imports/imports.rs 1 0.0%
crates/wasmtime-backend/src/lib.rs 4 0.0%
Totals Coverage Status
Change from base Build 6616846004: -0.001%
Covered Lines: 31
Relevant Lines: 7440

💛 - Coveralls

This was referenced Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants