Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spell): update to new mailbox [NET-505] #1694

Merged
merged 7 commits into from
Jul 14, 2023
Merged

feat(spell): update to new mailbox [NET-505] #1694

merged 7 commits into from
Jul 14, 2023

Conversation

justprosh
Copy link
Member

@justprosh justprosh commented Jul 10, 2023

Description

Update spells to 0.5.16 version and push to the updated mailbox.

Motivation

Previously KV was used to mailboxes

Related Issue(s)

Proposed Changes

Call push_mailbox instead of list_push_string to store trigger events

Screenshots (if applicable)

[Add any relevant screenshots or animated GIFs to showcase the changes.]

Additional Notes

[Provide any additional information or context that may be helpful for the reviewer.]

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear
Copy link

linear bot commented Jul 10, 2023

NET-505 Use rotating mailbox in nox

use rotating mailbox, not kv

@kmd-fl
Copy link
Contributor

kmd-fl commented Jul 14, 2023

You also need to update the spell service version.

What would happen with old spells? They don't have this function. We don't update the services of existing spells.

@justprosh justprosh added the e2e Run e2e workflow label Jul 14, 2023
@justprosh
Copy link
Member Author

You also need to update the spell service version.

What would happen with old spells? They don't have this function. We don't update the services of existing spells.

@kmd-fl i waited for release of new spell version

@justprosh
Copy link
Member Author

@kmd-fl oh, i got your concern 😅

@justprosh
Copy link
Member Author

@kmd-fl I will provide a fallback if push_mailbox fails and will write directly for KV

@justprosh justprosh enabled auto-merge (squash) July 14, 2023 16:55
@justprosh justprosh merged commit 15f1921 into master Jul 14, 2023
14 of 16 checks passed
@justprosh justprosh deleted the new_mailbox branch July 14, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants