Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): fixed listen address getting logic #1762

Merged
merged 3 commits into from
Aug 14, 2023
Merged

fix(http): fixed listen address getting logic #1762

merged 3 commits into from
Aug 14, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Aug 13, 2023

Description

Fix http listen address getting logic.

Motivation

Race found. On some machines channel drop happens before binding.

Proposed Changes

Made a more strict API. Fixed leaked channel.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu marked this pull request as ready for review August 13, 2023 12:45
crates/created-swarm/src/swarm.rs Outdated Show resolved Hide resolved
Co-authored-by: Aleksey Proshutisnkiy <justprosh@users.noreply.github.com>
@gurinderu gurinderu added the e2e Run e2e workflow label Aug 13, 2023
@folex folex merged commit 1205a79 into master Aug 14, 2023
22 checks passed
@folex folex deleted the fix_hang-2 branch August 14, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants