-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(system-services, tests): composable and overridable system services [NET-530, NET-531] #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurinderu
reviewed
Aug 25, 2023
gurinderu
reviewed
Aug 25, 2023
gurinderu
reviewed
Aug 25, 2023
gurinderu
reviewed
Aug 25, 2023
justprosh
reviewed
Aug 28, 2023
Co-authored-by: Aleksey Proshutisnkiy <justprosh@users.noreply.github.com>
…vices # Conflicts: # crates/system-services/src/deployer.rs
…t-peer into plugable-system-services
@justprosh @nick let's merge it maybe? |
folex
reviewed
Sep 12, 2023
folex
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decompose system services crate to be able to override and extend used system services.
Motivation
ATM the system services are build in the system service deployer. To modify them or to add new ones, you need to change the deployer itself. In this PR we introduce a way to define a system service separately from the deployer and deploy any provided set of services. Also, we extend the tests interface to be able to modify and created custom system services.
Proposed Changes
PackageDistro
structure to define a system service with all aux spells and services. I call a package, not a system service (since it's not a single service but a set of services) or a worker (since it's not installed on a separate worker) for clarity of the purpose, but we way rename it toSystemServiceDistro
, although I find the package concept more general. Probably, we can use this concept in FCLI to make re-usable and composable services.aqua-ipfs
,registry
and so on) outside of the deployer.Additional Notes
PackageDistro
for each system service in the corresponding system service distro crate, and import it.create-swarm
crate, but do it in a separate PR.