Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builtins): implement subnet.resolve [NET-549] #1798

Merged
merged 8 commits into from
Sep 21, 2023
Merged

Conversation

justprosh
Copy link
Member

@justprosh justprosh commented Sep 20, 2023

Description

Implement subnet resolver without explicitly providing endpoint and use endpoint from decider config.

Motivation

Clients should not be able to change endpoints and endpoint info (credentials, secrets, etc) should be public and changeable by third-parties.

Proposed Changes

  • add subnet.resolve builtin

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear
Copy link

linear bot commented Sep 20, 2023

NET-549 Add subnet.resolve builtin

get rpc endpoint from config

crates/subnet-resolver/src/resolve.rs Outdated Show resolved Hide resolved
crates/subnet-resolver/src/resolve.rs Outdated Show resolved Hide resolved
crates/subnet-resolver/src/utils.rs Show resolved Hide resolved
@justprosh justprosh added the e2e Run e2e workflow label Sep 21, 2023
@justprosh justprosh enabled auto-merge (squash) September 21, 2023 15:09
@justprosh justprosh merged commit 85665e2 into master Sep 21, 2023
14 checks passed
@justprosh justprosh deleted the subnet-resolve branch September 21, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants