Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(decider): allow to set ipfs multiaddr from env [fixes NET-544] #1802

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

justprosh
Copy link
Member

@justprosh justprosh commented Sep 22, 2023

Description

Allow to override decider ipfs multiaddr from ENV.

Motivation

It's necessary to flexibly configure noxes and crucial for local testing setup.

Proposed Changes

  • set decider ipfs multiaddr via `FLUENCE_ENV_DECIDER_IPFS_MULTIADDR
  • show overridden values in logs
  • bump aqua-ipfs to 0.5.20
  • allow to reconfigure aqua-ipfs

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear
Copy link

linear bot commented Sep 22, 2023

@justprosh justprosh added the e2e Run e2e workflow label Sep 22, 2023
@folex folex changed the title feat(decider): allow to set ipfs multiaddr from env [NET-544] feat(decider): allow to set ipfs multiaddr from env [fixes NET-544] Sep 22, 2023
@justprosh justprosh enabled auto-merge (squash) September 22, 2023 20:14
@justprosh justprosh merged commit a0606bc into master Sep 22, 2023
14 checks passed
@justprosh justprosh deleted the set_decider_ipfs branch September 22, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants