-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: verify particle signatures [NET-539] #1811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmd-fl
approved these changes
Sep 26, 2023
folex
approved these changes
Sep 27, 2023
folex
reviewed
Sep 27, 2023
Can you check on the ed25519 exploit, please? https://github.com/MystenLabs/ed25519-unsafe-libs/tree/main/ed25519-chalkias-exploit Check if it applies to us on current setup, and follow their recommendation regarding using |
gurinderu
reviewed
Sep 27, 2023
folex
reviewed
Oct 4, 2023
folex
reviewed
Oct 4, 2023
folex
reviewed
Oct 4, 2023
gurinderu
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verify particle signatures and drop incorrectly signed ones.
Motivation
Particle signatures are crucial for security and authentication.
Proposed Changes
id
as bytestimestamp
u64 as little-endian bytesttl
u32 as little-endian bytesscript
as bytesChecklist
Reviewer Checklist