Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: env configuration loading for protocol config #1814

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

gurinderu
Copy link
Contributor

Description

Fix protocol config configuration loading from env

Motivation

FLUENCE_PROTOCOL_CONFIG__UPGRADE_TIMEOUT doesn't work if another parameters from protocol config wasn't specified

Related Issue(s)

Proposed Changes

Screenshots (if applicable)

Additional Notes

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu marked this pull request as ready for review September 27, 2023 17:57
@gurinderu gurinderu added the e2e Run e2e workflow label Sep 27, 2023
@gurinderu gurinderu merged commit e8a11fe into master Sep 28, 2023
14 checks passed
@gurinderu gurinderu deleted the fix_upgrade_timeout_config branch September 28, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants