Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtins): validate deal_id in subnet.resolve [NET-591] #1842

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

justprosh
Copy link
Member

Description

Validate deal id in subnet.resolve, provide readable error, and append 0x if necessary

Motivation

subnet.resolve was failing in case of deal_id without 0x prefix and return unreadable errors in case of invalid deal ids

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@justprosh justprosh added the e2e Run e2e workflow label Oct 18, 2023
@justprosh justprosh changed the title fix(builtins): validate deal_id in subnet.resolve fix(builtins): validate deal_id in subnet.resolve [NET-591] Oct 18, 2023
@linear
Copy link

linear bot commented Oct 18, 2023

NET-591 Fix subnet.resolve

  • 0x absence shouldn't impact behavior, just add it
  • Errors should be actionable, eg "DealID is incorrect"
  • Validate input, check it to be the correct address.

@justprosh justprosh merged commit 84bc025 into master Oct 19, 2023
14 checks passed
@justprosh justprosh deleted the fix_resolve branch October 19, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants