Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nox): add new flags for system services [NET-547, NET-548] #1888

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Nov 8, 2023

Description

Add two new flags:

  • --wallet-key KEY
  • --enable-system-services=LIST
    • --enable-system-services=all to enable all available services
    • --enable-system-services=service1,service2 to enable only services from the list
    • --enable-system-services=none to disable all services (disabling now doesn't work, it will be introduce by some other task)

Also, make nox fail when a wallet key isn't set when decider is enabled.

Motivation

To be user-friendly

Additional Notes

These flags are introduced via the existing mechanism of layer configs, so we don't have a lot of control here.

Copy link

linear bot commented Nov 8, 2023

NET-547 Add flag to nox with wallet pk

It is required in case of decider deployment

NET-548 Add flag to nox for enable/disable system services

Add new flags enable-system-services that work like this

--enable-system-services=decider,registry,aqua-ipfs # enable only the services from the list
--enable-system-services=all # enable all known system services
--enable-system-services=none # don't enable any service

Later, we will stop the spells of the disabled services.
The list of known system services should be found in the help and error messages.

Unknown system service `asd`. Expected: decider, registry, trust-graph or aqua-ipfs

@kmd-fl kmd-fl added the e2e Run e2e workflow label Nov 9, 2023
@kmd-fl kmd-fl requested a review from folex November 9, 2023 12:28
@kmd-fl kmd-fl merged commit b172117 into master Nov 9, 2023
21 checks passed
@kmd-fl kmd-fl deleted the add-flags branch November 9, 2023 12:36
gurinderu pushed a commit that referenced this pull request Nov 14, 2023
* add new flags to set wallet-key and enable system services
* throw error when wallet key doesn't set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants