feat(subnet): Update resolver to new contracts [NET-619] #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurinderu
approved these changes
Nov 9, 2023
justprosh
approved these changes
Nov 10, 2023
folex
approved these changes
Nov 10, 2023
Co-authored-by: Aleksey Proshutinskiy <justprosh@users.noreply.github.com>
nahsi
reviewed
Nov 14, 2023
Co-authored-by: Anatolios Laskaris <github_me@nahsi.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested the nox and decider with new deal lifecycle update.
On deploy to stage/testnet/kras, need to set new addresses in the configs.
Proposed Changes
The format of the call was changed. Now the function named
getComputeUnitsand the result doesn't have theindexfield (which was ignored anyway)Additional Notes
What I did:
Results:
deal logsdidn't work; needed to changesubnet.resolve. After the change, it worked.