Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove insecured keypair [NET-633] #1906

Merged
merged 2 commits into from
Nov 15, 2023
Merged

feat: remove insecured keypair [NET-633] #1906

merged 2 commits into from
Nov 15, 2023

Conversation

justprosh
Copy link
Member

Description

Remove insecured keypair completely.

Motivation

We use on-chain subnet resolving instead of registry-based.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear Linear
Copy link

linear bot commented Nov 15, 2023

NET-633 Remove insecured keypair

@justprosh justprosh marked this pull request as ready for review November 15, 2023 12:32
@justprosh justprosh added the e2e Run e2e workflow label Nov 15, 2023
@justprosh justprosh enabled auto-merge (squash) November 15, 2023 12:33
@justprosh justprosh merged commit 32e938c into master Nov 15, 2023
26 of 27 checks passed
@justprosh justprosh deleted the remove-insecured-keypair branch November 15, 2023 13:35
@fluencebot fluencebot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurinderu gurinderu gurinderu approved these changes

@kmd-fl kmd-fl kmd-fl approved these changes

@folex folex Awaiting requested review from folex

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justprosh @gurinderu @kmd-fl