Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): Add tracing for understand particle processing #1935

Merged
merged 36 commits into from
Dec 15, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Nov 27, 2023

Description

Add tracing spans for the particle processing flow.

Motivation

Tracing can give information for understanding bottlenecks in the current system.

Proposed Changes

  • Added a wrapper for the particle + additional root span.
  • Used the root span as a parent span everywhere.

Additional Notes

  • The span is wrapped In the Arc because the span has a sent logic on the drop. It is much simpler to understand when the span is going to be dropped with Arc.
  • Added #[instrument] attribute with INFO level without serializing passed parameters as an additional span attributes for some async functions.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Nov 27, 2023

@gurinderu gurinderu changed the title feat(tracing): Add tracing to understand particle processing feat(tracing): Add tracing for understand particle processing Nov 27, 2023
@gurinderu gurinderu added the e2e Run e2e workflow label Nov 27, 2023
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu marked this pull request as ready for review November 27, 2023 21:41
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
aquamarine/src/aquamarine.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu requested a review from folex December 13, 2023 17:36
@gurinderu gurinderu enabled auto-merge (squash) December 14, 2023 14:41
@gurinderu gurinderu merged commit c800495 into master Dec 15, 2023
15 checks passed
@gurinderu gurinderu deleted the feature/net-641 branch December 15, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants