Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spells): allow empty args for callbackSrv [NET-651] #1942

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

justprosh
Copy link
Member

@justprosh justprosh commented Dec 2, 2023

Description

Don't throw an error in case of call spells' callbackSrv with empty args.

Motivation

Aqua now always adds call "callbackSrv" "response" [] even for fire-and-forget scripts, so spell scripts without explicit return calls always try to store empty responses.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Dec 2, 2023

@justprosh justprosh added the e2e Run e2e workflow label Dec 2, 2023
@justprosh justprosh merged commit 19e00be into master Dec 13, 2023
15 checks passed
@justprosh justprosh deleted the fix_calbackSrv branch December 13, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants