Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datastore): remove particles #1965

Merged
merged 6 commits into from
Dec 18, 2023
Merged

fix(datastore): remove particles #1965

merged 6 commits into from
Dec 18, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Dec 18, 2023 •
edited
Loading

Description

Partcile data file is a file. Use a remove file instead of remove dir

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu marked this pull request as ready for review December 18, 2023 09:01
@gurinderu gurinderu added the e2e Run e2e workflow label Dec 18, 2023
kmd-fl
kmd-fl reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@kmd-fl kmd-fl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reminder from the previous PR from folex: need tests for that

@gurinderu gurinderu merged commit 17e5e2e into master Dec 18, 2023
15 checks passed
@gurinderu gurinderu deleted the fix-dir-cleanup-2 branch December 18, 2023 14:01
@fluencebot fluencebot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmd-fl kmd-fl kmd-fl approved these changes

@folex folex Awaiting requested review from folex

@justprosh justprosh Awaiting requested review from justprosh

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gurinderu @kmd-fl