Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): respect base_dir in keypair generation #1998

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

folex
Copy link
Member

@folex folex commented Dec 28, 2023

Description

@nahsi asked:

Can we make nox to put keys to BASE_DIR/... by default instead of /.fluence?

It turns out, the current keypair generation does not respect base_dir property in config. It always uses /.fluence as a base dir, and puts key there.

Proposed Changes

Load and store keypairs relative to base_dir in Nox config.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@folex folex added the e2e Run e2e workflow label Dec 28, 2023
@folex folex enabled auto-merge (squash) December 28, 2023 21:32
@folex folex merged commit e2b99bf into master Dec 29, 2023
28 checks passed
@folex folex deleted the based_keypair branch December 29, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants