Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker_pool)!: Shift service creation to the worker pool [Fixes NET-716] #2026

Merged
merged 47 commits into from
Feb 2, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Jan 18, 2024

Description

This pull request contains the shifting of the service creation to the worker pool. Also, it has a separation of ParticleAppServices into the root & worker contexts.

Motivation

  • shifting motivation: we want to isolate each service creation per worker
  • context separation: we want to separate root & worker logic

Related Issue(s)

NET-716

Proposed Changes

Introduced PeerScope enum describes the current execution scope
ParticleAppServices - have separate structures for the root scope & worker scopes.
Workers can use a WorkerId only, doesn't work for the root worker.
PeerScope used everywhere instead of worker_id.

Screenshots (if applicable)

[Add any relevant screenshots or animated GIFs to showcase the changes.]

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Jan 18, 2024

@gurinderu gurinderu marked this pull request as ready for review January 29, 2024 10:20
@gurinderu gurinderu requested review from kmd-fl and justprosh and removed request for kmd-fl and justprosh January 29, 2024 10:26
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Jan 31, 2024
@gurinderu
Copy link
Contributor Author

I haven't finished reading the PR, but so far, I find that I don't like the PeerScope structure at all.

why?

@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Feb 2, 2024
particle-services/src/app_services.rs Outdated Show resolved Hide resolved
particle-services/src/app_services.rs Outdated Show resolved Hide resolved
crates/types/src/lib.rs Outdated Show resolved Hide resolved
crates/types/Cargo.toml Outdated Show resolved Hide resolved
@gurinderu gurinderu added the e2e Run e2e workflow label Feb 2, 2024
@gurinderu gurinderu merged commit d3e4855 into master Feb 2, 2024
22 checks passed
@gurinderu gurinderu deleted the feature/net-716 branch February 2, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants