Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(particle-data)!: use MsgPack for particle data serialization [Fixes VM-407] #2034

Merged
merged 9 commits into from
Jan 31, 2024

Conversation

monoid
Copy link
Contributor

@monoid monoid commented Jan 22, 2024

Description

Use multicodec-prefixed MsgPack for particle data serialization.

Motivation

MsgPack is more efficient format by memory, CPU and transmitted data size than JSON that was used before. The multicodec allows to change formats in incompatibility-detectable way and, in the future, support multiple formats.

Related Issue(s)

VM-407

Proposed Changes

Instead of asynchronous_codec::JsonCode which is not used in a synchronous context anyway, use AquaVM sede crate with multiformats support. The outer UveCodec is left as is.

Checklist

  • [🤔] The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@monoid monoid self-assigned this Jan 22, 2024
Copy link

linear bot commented Jan 22, 2024

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@monoid monoid marked this pull request as ready for review January 22, 2024 12:27
@gurinderu gurinderu changed the title feat(particle-data)!: use MsgPack for particle data serialization feat(particle-data)!: use MsgPack for particle data serialization [Fixes VM-407] Jan 22, 2024
@gurinderu gurinderu added the e2e Run e2e workflow label Jan 22, 2024
@nahsi nahsi merged commit 4d76e8f into master Jan 31, 2024
17 of 18 checks passed
@nahsi nahsi deleted the feat/VM-407-msgpack-particle branch January 31, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants