Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anomaly): new anomaly criteria [fixes vm-426] #2037

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

raftedproc
Copy link
Contributor

@raftedproc raftedproc commented Jan 24, 2024

Description

This patch adds new criteria to detect memory limits anomalies to collect statistics. The statistics will be used to adjust the mentioned memory limits.

Motivation

AquaVM hardening calls for hard memory limits to be able to fight against DoS.

Related Issue(s)

VM-426

Proposed Changes

Add new criteria.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Jan 24, 2024

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

@raftedproc raftedproc force-pushed the feat/vm-426-add-mem-limits-anomaly-detection branch from 6e09ad8 to 2976886 Compare January 24, 2024 06:15
Copy link

linear bot commented Jan 24, 2024

@folex folex added the e2e Run e2e workflow label Jan 26, 2024
@raftedproc raftedproc added e2e Run e2e workflow and removed e2e Run e2e workflow labels Jan 27, 2024
@gurinderu gurinderu merged commit d59b885 into master Jan 31, 2024
13 of 15 checks passed
@gurinderu gurinderu deleted the feat/vm-426-add-mem-limits-anomaly-detection branch January 31, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants