Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(health): add kademlia bootstrap healthcheck + fix test span logging #2056

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Feb 2, 2024

Description

Added a kademlia bootstrap health check.

Motivation

I hope it will fix some tests + reduce test difficulty related to Kad timeouts.

Additional Notes

  • nox node initialization is a parallel now
  • fixed span names in tests

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu changed the title chore: fix test span logging feat(health): add kademlia bootstrap healthcheck + fix test span logging Feb 5, 2024
@gurinderu gurinderu marked this pull request as ready for review February 5, 2024 09:55
@gurinderu gurinderu added the e2e Run e2e workflow label Feb 5, 2024
@gurinderu gurinderu requested review from kmd-fl, folex and justprosh and removed request for kmd-fl and folex February 5, 2024 11:29
@gurinderu gurinderu enabled auto-merge (squash) February 5, 2024 16:29
aquamarine/src/vm_pool.rs Outdated Show resolved Hide resolved
crates/created-swarm/src/swarm.rs Show resolved Hide resolved
@gurinderu gurinderu merged commit c082231 into master Feb 5, 2024
15 checks passed
@gurinderu gurinderu deleted the fix-test-logs-2 branch February 5, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants