Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(particle-vault)!: introduce new particle vault path format #2098

Merged
merged 25 commits into from
Feb 23, 2024

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Feb 21, 2024

Description

Introduce new particle vault features: new path format and write-only /tmp/vault

Motivation

Need to secure the particle vault to prevent unauthorized access to the vaults of others since we map shared vault directory into services (due to marine limitation)

Proposed Changes

  1. Use worker-id (host-id on host) as a part of the particle vault name
  2. In marine service, map /tmp/vault -> vault_dir/$worker_id
  3. Store particle_token in Actor to be able to clean the vault (:c)
  4. The vault name format now is /tmp/vault/$particle-id-$particle-token/
  5. Create a worker vault with write-only permission and a particle vault with RW permission for the cleanup procedure (it can't remove a directory recursively without the read permission). I create it on each service creation since it's the easiest place, but we'll need to move it
  6. Note that Worker Particle Vault won't be cleared, and if a worker is removed, the directory remains. It should be fixed with the ephemeral feature, I guess.
  7. Also, fix the problem with Spell KV Restriction: deployer can't re-deploy a spell due to the lack of privileges

Additional Notes

TODO:

@kmd-fl kmd-fl changed the base branch from master to support-new-call-params February 21, 2024 11:44
@kmd-fl kmd-fl changed the title feat(particle-vault): secure vault feat(particle-vault): introduce new particle vault path format Feb 21, 2024
@kmd-fl kmd-fl changed the title feat(particle-vault): introduce new particle vault path format feat(particle-vault)!: introduce new particle vault path format Feb 21, 2024
@kmd-fl kmd-fl added the e2e Run e2e workflow label Feb 21, 2024
Base automatically changed from support-new-call-params to master February 21, 2024 17:11
@folex folex requested a review from gurinderu February 22, 2024 00:52
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
@kmd-fl kmd-fl requested a review from folex February 23, 2024 13:43
@kmd-fl kmd-fl merged commit 3d68c85 into master Feb 23, 2024
15 checks passed
@kmd-fl kmd-fl deleted the new-vault branch February 23, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants