Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workers): separate AVM pools [fixes NET-753] #2125

Merged
merged 37 commits into from
Mar 8, 2024
Merged

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Mar 1, 2024

Description

Separate AVM pools for hosts and workers.

Motivation

Resource isolation.

Related Issue(s)

NET-753

Proposed Changes

  • Added a VmPool storage for workers into Plumber
  • Workers entity sends an event when a create/delete event happens. The plumber reacts to and creates the pool

Additional Notes

  • Actors storage for the hosts/workers is separate now.
  • Clippy fix applied :/
  • Metrics also separated by labels
  • Added hack for write_only_dir on macos

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Mar 1, 2024

nox/src/http.rs Outdated Show resolved Hide resolved
crates/workers/src/error.rs Outdated Show resolved Hide resolved
crates/workers/src/error.rs Outdated Show resolved Hide resolved
crates/workers/src/error.rs Outdated Show resolved Hide resolved
crates/workers/src/error.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu changed the title feat(workers): separete AVM pools feat(workers): separate AVM pools Mar 4, 2024
crates/workers/src/error.rs Outdated Show resolved Hide resolved
crates/workers/src/error.rs Outdated Show resolved Hide resolved
crates/workers/src/error.rs Outdated Show resolved Hide resolved
crates/workers/src/error.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Mar 4, 2024
@gurinderu gurinderu changed the title feat(workers): separate AVM pools feat(workers): separate AVM pools [fixes NET-753] Mar 5, 2024
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Mar 5, 2024
@gurinderu gurinderu marked this pull request as ready for review March 5, 2024 11:14
aquamarine/src/plumber.rs Outdated Show resolved Hide resolved
aquamarine/src/plumber.rs Outdated Show resolved Hide resolved
aquamarine/src/plumber.rs Outdated Show resolved Hide resolved
crates/workers/src/workers.rs Outdated Show resolved Hide resolved
crates/workers/src/workers.rs Outdated Show resolved Hide resolved
crates/workers/src/workers.rs Outdated Show resolved Hide resolved
Copy link
Member

@folex folex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done :)

aquamarine/src/plumber.rs Outdated Show resolved Hide resolved
aquamarine/src/plumber.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu enabled auto-merge (squash) March 8, 2024 10:23
@gurinderu gurinderu merged commit fd2552f into master Mar 8, 2024
17 checks passed
@gurinderu gurinderu deleted the feature/net-753 branch March 8, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants