Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): print config [fixes NET-796] #2161

Merged
merged 14 commits into from
Mar 12, 2024
Merged

fix(config): print config [fixes NET-796] #2161

merged 14 commits into from
Mar 12, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Mar 12, 2024

Description

Print config in toml format if argument provided.

Related Issue(s)

NET-796

Proposed Changes

Tracing subscriber is available before the tokio context now. Otlp layer will be initialized later when tokio context is available. Also dropped log config from app config, log format can be changed only with FLUENCE_LOG_FORMAT env

Additional Notes

  • Removed unused crates
  • Updated toml to the latest version (current doesn't work). Keep old version only in the few places to make compiler happy.
  • Unfortunately, dropped a tokio console layer. It doesn't work.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Mar 12, 2024

@gurinderu gurinderu marked this pull request as ready for review March 12, 2024 10:59
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Mar 12, 2024
@gurinderu gurinderu requested review from folex, justprosh and kmd-fl and removed request for folex March 12, 2024 11:39
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Mar 12, 2024
@gurinderu gurinderu added the e2e Run e2e workflow label Mar 12, 2024
@gurinderu gurinderu merged commit c1d58b5 into master Mar 12, 2024
20 checks passed
@gurinderu gurinderu deleted the feature/net-796 branch March 12, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants