Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-manager): add dev core manager to support any number of CUs [fixes NET-799] #2167

Merged
merged 6 commits into from
Mar 20, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Mar 15, 2024

Description

New core manager implementation - not so strict as a production. Allows to run deals more than available CPUs.

Motivation

For the dev mode, we should have the ability to create a lot of deals.

Related Issue(s)

NET-799

Proposed Changes

Added a separate dev core manager

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Mar 15, 2024

NET-799 Dev core manager

@gurinderu gurinderu marked this pull request as ready for review March 15, 2024 11:56
@gurinderu gurinderu added the e2e Run e2e workflow label Mar 15, 2024
@gurinderu gurinderu requested review from kmd-fl, justprosh and folex and removed request for kmd-fl March 15, 2024 12:09
@folex folex changed the title feat(core-manager): dev core manager [fixes NET-799] feat(core-manager): add dev core manager to support any number of CUs [fixes NET-799] Mar 15, 2024
@kmd-fl
Copy link
Contributor

kmd-fl commented Mar 18, 2024

Checked in local up: fluence local up, fluence deal deploy, fluence run -f 'runDeployedServices()' worked. My laptop started to lag. I think it lagged more than before, but that is only my perception, no measures; local up is quite greedy in general.

@gurinderu gurinderu merged commit e061413 into master Mar 20, 2024
14 checks passed
@gurinderu gurinderu deleted the feature/net-799 branch March 20, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants