Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-manager)!: use hex format for CUIDs [fixes NET-804] #2188

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

gurinderu
Copy link
Contributor

Description

Use hex format for CUIDs instead of byre arrays.

Motivation

Byte arrays aren't human-readable

Related Issue(s)

NET-804

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Mar 20, 2024

@gurinderu gurinderu marked this pull request as ready for review March 20, 2024 12:26
@gurinderu gurinderu changed the title fix(core-manager): use hex format for CUIDs [fixes NET-804] fix(core-manager)!: use hex format for CUIDs [fixes NET-804] Mar 20, 2024
@gurinderu gurinderu added the e2e Run e2e workflow label Mar 20, 2024
@gurinderu gurinderu merged commit 415f917 into master Mar 20, 2024
21 checks passed
@gurinderu gurinderu deleted the feature/net-804 branch March 20, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants