Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime)!: use async marine [fixes VM-365,NET-758,NET-757] #2206

Merged
merged 33 commits into from
Apr 24, 2024

Conversation

ValeryAntopol
Copy link
Contributor

@ValeryAntopol ValeryAntopol commented Mar 27, 2024

Description

Introduce async marine runtime.

Motivation

[Explain why these changes are necessary or beneficial. Discuss any problems or limitations with the current implementation that this pull request addresses.]

Related Issue(s)

VM-365
NET-758
NET-757

Additional Notes

  • increase threads requirements for some tests
  • introduced a shared wasm backend for all AVM instances instead of creating it for each AVM instance
  • a separate marine config for AVM & services
  • move to async calls where it needed
  • added a new option for the test client with disabled reconnection
  • fixed the graceful shutdown for the nox process
  • moved ServicesConfig to particle-services crate and renamed to ParticleAppServicesConfig
  • refactored Init flow for the system-services

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

aquamarine/src/spawner.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu added the e2e Run e2e workflow label Apr 12, 2024
@gurinderu gurinderu changed the title feat(runtime)!: use async marine feat(runtime)!: use async marine [fixes VM-365,NET-758,NET-757] Apr 12, 2024
@gurinderu gurinderu requested a review from kmd-fl April 12, 2024 12:46
@gurinderu gurinderu mentioned this pull request Apr 22, 2024
1 task
@gurinderu gurinderu merged commit 3994299 into master Apr 24, 2024
14 checks passed
@gurinderu gurinderu deleted the feat/async-marine branch April 24, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants