Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cc): Continue CCP calculation if cpu_cores < cu_number [fixes NET-808] #2207

Merged
merged 16 commits into from
Apr 10, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Mar 28, 2024

Description

Add a warning message if commitment > available host CPU count. + minor fixes

Related Issue(s)

NET-808

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu changed the title wup fix(cc): wip Mar 29, 2024
@gurinderu gurinderu changed the title fix(cc): wip fix(cc): Continue CCP calculation if cpu_cores < cu_number [fixes NET-808] Apr 1, 2024
Copy link

linear bot commented Apr 1, 2024

@gurinderu gurinderu marked this pull request as ready for review April 1, 2024 16:59
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Apr 1, 2024
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Apr 4, 2024
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Apr 5, 2024
@gurinderu gurinderu requested a review from folex April 9, 2024 12:10
Copy link
Member

@folex folex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so many clones in refresh_commitment, it makes it super hard to follow the logic.

crates/chain-listener/src/listener.rs Outdated Show resolved Hide resolved
crates/chain-listener/src/listener.rs Outdated Show resolved Hide resolved
crates/chain-listener/src/listener.rs Outdated Show resolved Hide resolved
crates/chain-listener/src/listener.rs Outdated Show resolved Hide resolved
crates/chain-listener/src/listener.rs Outdated Show resolved Hide resolved
crates/chain-listener/src/listener.rs Outdated Show resolved Hide resolved
crates/core-manager/src/dev.rs Show resolved Hide resolved
crates/core-manager/src/dev.rs Show resolved Hide resolved
crates/core-manager/src/dev.rs Outdated Show resolved Hide resolved
crates/core-manager/src/types.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu added the e2e Run e2e workflow label Apr 9, 2024
@gurinderu gurinderu requested a review from folex April 9, 2024 20:23
Copy link
Member

@folex folex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gurinderu gurinderu merged commit d3d5f27 into master Apr 10, 2024
14 checks passed
@gurinderu gurinderu deleted the log-wrong-commitment branch April 10, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants