Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chain-connector): make connector generic #2229

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Conversation

gurinderu
Copy link
Contributor

Description

Generic cnain connector.

Motivation

Allows to mock it in tests

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu marked this pull request as ready for review April 17, 2024 12:38
crates/chain-connector/src/connector.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Apr 17, 2024
@gurinderu gurinderu merged commit 90957a6 into master Apr 17, 2024
20 checks passed
@gurinderu gurinderu deleted the generic_chain_connector branch April 17, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants