Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network)!: Network isolation [fixes NET-818] #2245

Merged
merged 18 commits into from
May 30, 2024
Merged

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented May 10, 2024

Description

Introduces a segregated kademlia protocol.

Motivation

It is possible to use a dar network from another network.

Related Issue(s)

NET-818

Proposed Changes

Introduced a schema with different kademlia protocols /fluence/kad/$id/1.0.0, where ID is the name of the network or custom ID for the private networking

Additional Notes

  • Split configs by domains.
  • Removed unused deps

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu marked this pull request as ready for review May 10, 2024 15:57
@gurinderu gurinderu added the e2e Run e2e workflow label May 10, 2024
@gurinderu gurinderu requested a review from folex May 20, 2024 14:13
nox/src/behaviour/network.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu requested review from folex and kmd-fl May 28, 2024 13:02
@gurinderu gurinderu changed the title feat(network): Network isolation feat(network): Network isolation [fixes NET-818] May 28, 2024
Copy link

linear bot commented May 28, 2024

nox/src/behaviour/identify.rs Outdated Show resolved Hide resolved
nox/src/node.rs Outdated Show resolved Hide resolved
Copy link
Member

@folex folex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the Identify protocol handler API, LGTM.

@gurinderu gurinderu changed the title feat(network): Network isolation [fixes NET-818] feat(network)!: Network isolation [fixes NET-818] May 30, 2024
@gurinderu gurinderu enabled auto-merge (squash) May 30, 2024 11:36
@gurinderu gurinderu merged commit f5eb980 into master May 30, 2024
14 checks passed
@gurinderu gurinderu deleted the network-isolation branch May 30, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants